-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(samsung_pay): populate payment_method_data
in the payment response
#7095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
kashif-m
previously approved these changes
Jan 23, 2025
kashif-m
previously approved these changes
Jan 23, 2025
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 23, 2025
kashif-m
approved these changes
Jan 24, 2025
Chethan-rao
approved these changes
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
pixincreate
added a commit
that referenced
this pull request
Feb 4, 2025
…-connectors * 'main' of github.com:juspay/hyperswitch: ci: disable stripe in cypress (#7183) fix(router): [Cybersource] add flag to indicate final capture (#7085) fix: invalidate surcharge cache during update (#6907) chore(version): 2025.02.04.0 fix(samsung_pay): populate `payment_method_data` in the payment response (#7095) feat(router): add core changes for external authentication flow through unified_authentication_service (#7063) fix(connector): [NETCETERA] add `sdk-type` and `default-sdk-type` in netcetera authentication request (#7156)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payment-methods
Area: Payment Methods
C-bug
Category: Bug
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pr contains the changes to populate
payment_method_data
in the samsung pay payment response. As part of this card_type is made a optional for wallet payment_method_data as samsung pay does not send credit or debit in the samsung pay token.Additional Changes
Motivation and Context
Having
payment_method_data
for Samsung Pay would be helpful in identifying the customer's card, as it contains the last four digits during a wallet payment.How did you test it?
-> Create a connector with samsung pay enabled
-> Make a samsung pay payment, payment_method_data would be populated in the resposne.
Checklist
cargo +nightly fmt --all
cargo clippy